[Webkit-unassigned] [Bug 173150] Add API::GeolocationProvider

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173150

--- Comment #6 from Darin Adler <darin at apple.com> ---
(In reply to Carlos Garcia Campos from comment #5)
> (In reply to Alex Christensen from comment #4)
> > > Source/WebKit2/UIProcess/WebGeolocationManagerProxy.h:50
> > > +    void setProvider(std::unique_ptr<API::GeolocationProvider>);
> > 
> > &&
> 
> That was also my idea at first, but then again I followed what we do for all
> other clients. In this particular case, I think that what we have is
> equivalent to && because we always pass a std::make_unique<> (or nullptr) to
> the function, so there aren't copies anyway.

I don’t know if we ever resolved this. Here is what Scott Meyers has to say:

http://scottmeyers.blogspot.com/2014/07/should-move-only-types-ever-be-passed.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170612/5e917e32/attachment.html>