[Webkit-unassigned] [Bug 173150] Add API::GeolocationProvider

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173150

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Alex Christensen from comment #4)
> Comment on attachment 312677 [details]
> Rebased patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312677&action=review
> 
> > Source/WebKit2/UIProcess/WebGeolocationManagerProxy.h:50
> > +    void setProvider(std::unique_ptr<API::GeolocationProvider>);
> 
> &&

That was also my idea at first, but then again I followed what we do for all other clients. In this particular case, I think that what we have is equivalent to && because we always pass a std::make_unique<> (or nullptr) to the function, so there aren't copies anyway.

> > Source/WebKit2/UIProcess/WebGeolocationProvider.h:44
> > +class WebGeolocationProvider : public API::GeolocationProvider,  API::Client<WKGeolocationProviderBase> {
> 
> extra space

Good catch!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170612/14c25b87/attachment.html>