[Webkit-unassigned] [Bug 173094] [GTK] Get rid of custom marshallers of signals

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=173094

Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mcatanzaro at igalia.com

--- Comment #5 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Good cleanup.

(In reply to Carlos Garcia Campos from comment #3)
> g_signal_new is already difficult to read with severl 0, nullptr, nullptr.
> In some cases we even add a comment explaining what the nullptr/0 is. So, I
> prefer to pass the marshaller for readability.

Well it's up to you, but I prefer the NULL/nullptr style as well. It's simpler than writing out g_cclosure_marshal_generic, and I don't think it hurts readability. Here nullptr means "keep things as the default" and that's all you need to know. I converted Epiphany to use this style a year or two ago.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170608/191435f9/attachment-0001.html>