[Webkit-unassigned] [Bug 173094] [GTK] Get rid of custom marshallers of signals

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 8 06:38:38 PDT 2017


Zan Dobersek <zan at falconsigh.net> changed:

           What    |Removed                     |Added
 Attachment #312293|review?                     |review+
              Flags|                            |

--- Comment #4 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 312293
  --> https://bugs.webkit.org/attachment.cgi?id=312293

View in context: https://bugs.webkit.org/attachment.cgi?id=312293&action=review

>>> Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp:87
>>> +        g_cclosure_marshal_generic,
>> You could as well pass “nullptr” here. According to the documentation for “g_signal_new()”
>> (https://developer.gnome.org/gobject/stable/gobject-Signals.html#g-signal-new):
> g_signal_new is already difficult to read with severl 0, nullptr, nullptr. In some cases we even add a comment explaining what the nullptr/0 is. So, I prefer to pass the marshaller for readability.

SGTM. Let's be explicit where possible.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170608/ca8b46b5/attachment.html>

More information about the webkit-unassigned mailing list