[Webkit-unassigned] [Bug 172958] check-webkit-style: validate 'specification' values in features.json

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=172958

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #4 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
(In reply to David Kilzer (:ddkilzer) from comment #3)
> So jsonchecker.py has a check for this exact thing.  I wonder why it didn't
> run?

Runs locally when I specify the file:

$ ./Tools/Scripts/check-webkit-style Source/JavaScriptCore/features.json 
ERROR: Source/JavaScriptCore/features.json:0:  The features should be sorted alphabetically by name, "Block Scoping" appears after "async/await".  [json/syntax] [5]
ERROR: Source/JavaScriptCore/features.json:0:  The feature "Object rest/spread" has a specification field but no specification of that name exists.  [json/syntax] [5]
Total errors found: 2 in 1 files

And if I back up to the revision before and then reapply the patch locally:

$ git checkout b678b94bdcb57fd1d1ef831097147147910c6b60^
Note: checking out 'b678b94bdcb57fd1d1ef831097147147910c6b60^'.
[...]

$ git diff b678b94bdcb57fd1d1ef831097147147910c6b60^..b678b94bdcb57fd1d1ef831097147147910c6b60 | patch -p1
patching file Source/JavaScriptCore/ChangeLog
patching file Source/JavaScriptCore/features.json

$ ./Tools/Scripts/check-webkit-style 
ERROR: Source/JavaScriptCore/features.json:0:  The features should be sorted alphabetically by name, "Block Scoping" appears after "async/await".  [json/syntax] [5]
ERROR: Source/JavaScriptCore/features.json:0:  The feature "Object rest/spread" has a specification field but no specification of that name exists.  [json/syntax] [5]
Total errors found: 2 in 2 files

So it seems like check-webkit-patch wasn't run because the patch was landed directly instead of going through the usual process of being posted to Bug 172942 and having check-webkit-style process it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170606/89dccf34/attachment.html>