[Webkit-unassigned] [Bug 172958] check-webkit-style: validate 'specification' values in features.json

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 6 10:01:35 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=172958

--- Comment #3 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
(In reply to David Kilzer (:ddkilzer) from comment #2)
> The assumption that was missed in Bug 172942 was that there is a top-level
> 'specification' object for each 'specification' value in every 'feature'.

So jsonchecker.py has a check for this exact thing.  I wonder why it didn't run?

<https://trac.webkit.org/browser/webkit/trunk/Tools/Scripts/webkitpy/style/checkers/jsonchecker.py#L107>

    if 'specification' in feature:
        if feature['specification'] not in specification_name_set:
            self._handle_style_error(0, 'json/syntax', 5, 'The feature "%s" has a specification field but no specification of that name exists.' % feature_name)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170606/9e10a879/attachment-0001.html>


More information about the webkit-unassigned mailing list