[Webkit-unassigned] [Bug 174861] WebDriver: fix return value of close window command

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 26 22:51:05 PDT 2017


--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Brian Burg from comment #3)
> Comment on attachment 316445 [details]
> Patch
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316445&action=review
> Absent a good justification, I don't want to add a redundant command. The
> web service parts look good.
> > Source/WebDriver/Session.cpp:308
> > +void Session::continueGetWindowHandles(const InspectorObject& result, Function<void (CommandResult&&)>&& completionHandler)
> Nit: I prefer "fetchWindowHandles" or just "getWindowHandles".

There's already getWindowHandles, this is what we call when we get the response of getWindowHandles.

> > Source/WebKit/UIProcess/Automation/Automation.json:250
> > +            "returns": [
> I don't like this. It's redundant with another command. Can you just compose
> the two Automation commands in the service implementation? That's what
> safaridriver does.

Yes, I just thought it was more convenient, and it simplifies the implementation in the driver.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170727/f5ab9247/attachment-0001.html>

More information about the webkit-unassigned mailing list