[Webkit-unassigned] [Bug 174861] WebDriver: fix return value of close window command
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 26 15:19:57 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=174861
Brian Burg <bburg at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #316445|review? |review-
Flags| |
--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 316445
--> https://bugs.webkit.org/attachment.cgi?id=316445
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=316445&action=review
Absent a good justification, I don't want to add a redundant command. The web service parts look good.
> Source/WebDriver/Session.cpp:308
> +void Session::continueGetWindowHandles(const InspectorObject& result, Function<void (CommandResult&&)>&& completionHandler)
Nit: I prefer "fetchWindowHandles" or just "getWindowHandles".
> Source/WebKit/UIProcess/Automation/Automation.json:250
> + "returns": [
I don't like this. It's redundant with another command. Can you just compose the two Automation commands in the service implementation? That's what safaridriver does.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170726/d30656a7/attachment-0001.html>
More information about the webkit-unassigned
mailing list