[Webkit-unassigned] [Bug 174784] [WinCairo] Fix build with AllInOnes disabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 24 18:31:22 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174784

--- Comment #9 from Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa at sony.com> ---
(In reply to Alex Christensen from comment #5)
> > Source/WebCore/PlatformWin.cmake:152
> > +if (NOT ENABLE_ALLINONE_BUILD)
> 
> We shouldn't need to check this.  IIRC, the all-in-one build removes files
> from WebCore_SOURCES.

PROCESS_ALLINONE_FILE() for WebCore_SOURCES is called before including PlatformWin.cmake so RenderThemeWin.cpp is not removed by the macro.

Like other ports, it would be more simple to exclude platform RenderTheme from RenderingAllInOne.cpp

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170725/4ad4a5c1/attachment.html>


More information about the webkit-unassigned mailing list