[Webkit-unassigned] [Bug 174784] [WinCairo] Fix build with AllInOnes disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174784

--- Comment #8 from Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa at sony.com> ---
(In reply to Alex Christensen from comment #7)
> Comment on attachment 316288 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316288&action=review
> 
> We are trying to reduce the number of headers that include other headers, so
> adding #include "DOMWindow.h" to more headers would be easy, but it would
> slow down the build.  This is better than that.

I understand.

> > Source/WebCore/rendering/RenderMediaControls.h:30
> > +#include "MediaControlElementTypes.h"
> 
> This entire header and cpp could probably be removed.
> 
> > Source/WebCore/testing/MemoryInfo.h:34
> > +#include "DOMWindow.h"
> 
> Could we add #include "DOMWindow.h" to some cpp files instead of this?

Probably we could remove #include "JSDOMWindow.h" from Source/WebCore/testing/MemoryInfo.h

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170725/1043552d/attachment-0001.html>