[Webkit-unassigned] [Bug 174784] [WinCairo] Fix build with AllInOnes disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174784

--- Comment #6 from Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa at sony.com> ---
(In reply to Alex Christensen from comment #5)

Thank you for reviewing!

> It's strange that we need to include DOMWindow.h in so many places.  Other
> platforms don't build with the all-in-one files.  This leads me to believe
> that there might be something wrong with this approach.

The DOMWindow class is forward-declared in "JSDOMWindowBase.h" and the JSDOMWindowBase 
class has a member "RefPtr<DOMWindow> m_wrapped;" so it seems that the sources
which include "JSDomWindowBase.h" need the definition of the DOMWindow class
somewhere in the compilation unit.

https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/bindings/js/JSDOMWindowBase.h#L28

Another solution would be to include "DOMWindow.h" in "JSDomWindowBase.h".

> > Source/WebCore/PlatformWin.cmake:152
> > +if (NOT ENABLE_ALLINONE_BUILD)
> 
> We shouldn't need to check this.  IIRC, the all-in-one build removes files
> from WebCore_SOURCES.

Let me check.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170724/9f70583d/attachment.html>