[Webkit-unassigned] [Bug 174784] [WinCairo] Fix build with AllInOnes disabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 24 11:21:25 PDT 2017


https://bugs.webkit.org/show_bug.cgi?id=174784

--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 316288
  --> https://bugs.webkit.org/attachment.cgi?id=316288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316288&action=review

It's strange that we need to include DOMWindow.h in so many places.  Other platforms don't build with the all-in-one files.  This leads me to believe that there might be something wrong with this approach.

> Source/WebCore/PlatformWin.cmake:152
> +if (NOT ENABLE_ALLINONE_BUILD)

We shouldn't need to check this.  IIRC, the all-in-one build removes files from WebCore_SOURCES.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170724/f529b0ac/attachment.html>


More information about the webkit-unassigned mailing list