[Webkit-unassigned] [Bug 174331] Add setup script for Web Driver part of Benchmark Runner script

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 20 14:32:12 PDT 2017


--- Comment #15 from dewei_zhu at apple.com ---
Comment on attachment 316011
  --> https://bugs.webkit.org/attachment.cgi?id=316011

View in context: https://bugs.webkit.org/attachment.cgi?id=316011&action=review

> Tools/ChangeLog:6
> +        Reviewed by Dean Johnson.


> Tools/Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:38
> +    def get_webdriver_binary_path(self):
> +        return get_driver_binary_path(self.browser_name)

This looks good enough. It would even better if we use @property here since it makes the code cleaner. Then rather than calling it get_webdriver_binary_path, we can just call it webdriver_binary_path,

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170720/f256fc32/attachment.html>

More information about the webkit-unassigned mailing list