[Webkit-unassigned] [Bug 174393] AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 11 16:55:54 PDT 2017
https://bugs.webkit.org/show_bug.cgi?id=174393
--- Comment #5 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 315175
--> https://bugs.webkit.org/attachment.cgi?id=315175
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=315175&action=review
> Source/WebCore/accessibility/AXObjectCache.cpp:1756
> + auto range = Range::create(m_document, startPosition, originalRange->startPosition());
does auto handle the RefPtr<Range> creation so that this gets released?
> Tools/DumpRenderTree/AccessibilityUIElement.cpp:1488
> + JSStringRef searchText = 0;
nullptr
> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:626
> + NSArray *textMarkers = [NSArray arrayWithObjects:(id)startMarker->platformTextMarker(), (id)endMarker->platformTextMarker(), nil];
do we need to worry that startMarker->platformTextMarker() might be null?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170711/6750d2e5/attachment.html>
More information about the webkit-unassigned
mailing list