[Webkit-unassigned] [Bug 174393] AX: [iOS] Implement a way to retrieve a text marker range with desired text that is closest to a position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174393

--- Comment #6 from Nan Wang <n_wang at apple.com> ---
Comment on attachment 315175
  --> https://bugs.webkit.org/attachment.cgi?id=315175
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=315175&action=review

>> Source/WebCore/accessibility/AXObjectCache.cpp:1756
>> +    auto range = Range::create(m_document, startPosition, originalRange->startPosition());
> 
> does auto handle the RefPtr<Range> creation so that this gets released?

Range::create will generate a reference, Range&

>> Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm:626
>> +    NSArray *textMarkers = [NSArray arrayWithObjects:(id)startMarker->platformTextMarker(), (id)endMarker->platformTextMarker(), nil];
> 
> do we need to worry that startMarker->platformTextMarker() might be null?

Ok

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170712/127296d7/attachment.html>