[Webkit-unassigned] [Bug 174239] WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174239

--- Comment #4 from Ansh Shukla <ansh_shukla at apple.com> ---
Comment on attachment 314819
  --> https://bugs.webkit.org/attachment.cgi?id=314819
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314819&action=review

>> Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeaturesPrivate.h:37
>> + at property (nonatomic, readonly, getter=_isDialog) BOOL _dialog WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> 
> These should be exposed as NSNumber *s the same way the API bool properties are.

width, height, x, and y are the only API::WindowFeature properties that are optional. All others are always specified, and the documentation on the public API is incorrect because, for example, menuBarVisibility can never be nil. If I'm right, then I don't think we should bring this mistake into the private API. I can change these to NSNumber * if I'm misinterpreting when values can be unspecified or if you think it's better to keep it consistent regardless.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170707/604c731d/attachment.html>