[Webkit-unassigned] [Bug 174239] WKWindowFeatures needs to expose scrollbar, fullscreen, and dialog configuration properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=174239

Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |beidson at apple.com
 Attachment #314819|review?                     |review-
              Flags|                            |

--- Comment #3 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 314819
  --> https://bugs.webkit.org/attachment.cgi?id=314819
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=314819&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKWindowFeaturesPrivate.h:37
> + at property (nonatomic, readonly, getter=_isLocationBarVisible) BOOL _locationBarVisible WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> + at property (nonatomic, readonly, getter=_areScrollbarsVisible) BOOL _scrollbarsVisible WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> + at property (nonatomic, readonly, getter=_isFullscreen) BOOL _fullscreen WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));
> + at property (nonatomic, readonly, getter=_isDialog) BOOL _dialog WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

These should be exposed as NSNumber *s the same way the API bool properties are.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170707/529b3299/attachment.html>