[Webkit-unassigned] [Bug 167509] [GTK] Add API to handle the accelerated compositing policy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 27 10:40:50 PST 2017


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #299940|review?                     |review+
              Flags|                            |

--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 299940
  --> https://bugs.webkit.org/attachment.cgi?id=299940

View in context: https://bugs.webkit.org/attachment.cgi?id=299940&action=review

> Source/WebKit2/ChangeLog:8
> +        Now that we have brought back the on demand mode, we should allow applications to choose the policy, wihtout

wihtout -> without

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1298
> +     * by using %WEBKIT_HARDWARE_ACCELERATION_POLICY_ALWAYS. And it's also posible to diaable it

diaable -> disable

> Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3253
> +    if (changed)
> +        g_object_notify(G_OBJECT(settings), "hardware-acceleration-policy");

It's a bit iffy how to handle this, but I would prefer to check the existing value of our API setting and notify if it changes, to close any possibility of notifying if the API setting doesn't change.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170127/129a6340/attachment.html>

More information about the webkit-unassigned mailing list