<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:mcatanzaro&#64;igalia.com" title="Michael Catanzaro &lt;mcatanzaro&#64;igalia.com&gt;"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK] Add API to handle the accelerated compositing policy"
   href="https://bugs.webkit.org/show_bug.cgi?id=167509">bug 167509</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #299940 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK] Add API to handle the accelerated compositing policy"
   href="https://bugs.webkit.org/show_bug.cgi?id=167509#c2">Comment # 2</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - [GTK] Add API to handle the accelerated compositing policy"
   href="https://bugs.webkit.org/show_bug.cgi?id=167509">bug 167509</a>
              from <span class="vcard"><a class="email" href="mailto:mcatanzaro&#64;igalia.com" title="Michael Catanzaro &lt;mcatanzaro&#64;igalia.com&gt;"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=299940&amp;action=diff" name="attach_299940" title="Patch">attachment 299940</a> <a href="attachment.cgi?id=299940&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299940&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=299940&amp;action=review</a>

<span class="quote">&gt; Source/WebKit2/ChangeLog:8
&gt; +        Now that we have brought back the on demand mode, we should allow applications to choose the policy, wihtout</span >

wihtout -&gt; without

<span class="quote">&gt; Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:1298
&gt; +     * by using %WEBKIT_HARDWARE_ACCELERATION_POLICY_ALWAYS. And it's also posible to diaable it</span >

diaable -&gt; disable

<span class="quote">&gt; Source/WebKit2/UIProcess/API/gtk/WebKitSettings.cpp:3253
&gt; +    if (changed)
&gt; +        g_object_notify(G_OBJECT(settings), &quot;hardware-acceleration-policy&quot;);</span >

It's a bit iffy how to handle this, but I would prefer to check the existing value of our API setting and notify if it changes, to close any possibility of notifying if the API setting doesn't change.</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>