[Webkit-unassigned] [Bug 167414] [GTK] Icon Database should be in private browsing mode for ephemeral web views

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 25 08:39:00 PST 2017


Michael Catanzaro <mcatanzaro at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #299687|review?                     |review+
              Flags|                            |

--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 299687
  --> https://bugs.webkit.org/attachment.cgi?id=299687

View in context: https://bugs.webkit.org/attachment.cgi?id=299687&action=review

Exactly the sort of thing I was worried about with allowing a per-view ephemeral setting... will there be more?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:785
> +        // We notify the context here to ensure it's called only once. Ideally we should
> +        // call this in finalize, not dispose, but finalize is used internally and we don't
> +        // have access to the instance pointer from the private struct destructor.
> +        webkitWebContextWebViewDestroyed(webView->priv->context.get(), webView);

I don't understand this. Of course you can move the call to webkitWebContextWebViewDestroyed finalize? Why not? What do you mean it's used internally?

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:163
> +static void testPrivateBrowsing(FaviconDatabaseTest* test)

Shouldn't you add a test for an ephemeral web context as well?

> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:173
> +    // An ephemeral web view should nto write to the database.

nto -> not

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170125/89d28d31/attachment.html>

More information about the webkit-unassigned mailing list