<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Icon Database should be in private browsing mode for ephemeral web views"
href="https://bugs.webkit.org/show_bug.cgi?id=167414">bug 167414</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #299687 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Icon Database should be in private browsing mode for ephemeral web views"
href="https://bugs.webkit.org/show_bug.cgi?id=167414#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Icon Database should be in private browsing mode for ephemeral web views"
href="https://bugs.webkit.org/show_bug.cgi?id=167414">bug 167414</a>
from <span class="vcard"><a class="email" href="mailto:mcatanzaro@igalia.com" title="Michael Catanzaro <mcatanzaro@igalia.com>"> <span class="fn">Michael Catanzaro</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=299687&action=diff" name="attach_299687" title="Patch">attachment 299687</a> <a href="attachment.cgi?id=299687&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299687&action=review">https://bugs.webkit.org/attachment.cgi?id=299687&action=review</a>
Exactly the sort of thing I was worried about with allowing a per-view ephemeral setting... will there be more?
<span class="quote">> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:785
> + // We notify the context here to ensure it's called only once. Ideally we should
> + // call this in finalize, not dispose, but finalize is used internally and we don't
> + // have access to the instance pointer from the private struct destructor.
> + webkitWebContextWebViewDestroyed(webView->priv->context.get(), webView);</span >
I don't understand this. Of course you can move the call to webkitWebContextWebViewDestroyed finalize? Why not? What do you mean it's used internally?
<span class="quote">> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:163
> +static void testPrivateBrowsing(FaviconDatabaseTest* test)</span >
Shouldn't you add a test for an ephemeral web context as well?
<span class="quote">> Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:173
> + // An ephemeral web view should nto write to the database.</span >
nto -> not</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>