[Webkit-unassigned] [Bug 167171] Additional selection tests and interpolation fix

Wed Jan 18 13:32:55 PST 2017

https://bugs.webkit.org/show_bug.cgi?id=167171

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299173|review?                     |review+
              Flags|                            |

--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 299173
  --> https://bugs.webkit.org/attachment.cgi?id=299173
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299173&action=review

> LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html:17
> +                        uiController.uiScriptComplete();
> +                });

Weird spacing.

> LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html:35
> +                        {

I think canonical formatting would outdent this paren.

> LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html:83
> +                    testRunner.runUIScript(getDragScript(55,90,0,90), function(result) {
> +                        if (document.getSelection().toString() == "aliqua. Ut")

I'm a bit concerned that small changes in text rendering (that often happen between OS releases) would break this test. Maybe make the text monospaced and of a fairly large size to reduce the likelihood.

> LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html:137
> +    <meta name="viewport" content="initial-scale=1">

We usually put this at the top of the <head>. I think your test needs the flexibleViewport flag to make this do anything.

> LayoutTests/fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html:16
> +                        uiController.uiScriptComplete();

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170118/4dbf0282/attachment.html>