<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Additional selection tests and interpolation fix"
href="https://bugs.webkit.org/show_bug.cgi?id=167171">bug 167171</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #299173 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Additional selection tests and interpolation fix"
href="https://bugs.webkit.org/show_bug.cgi?id=167171#c3">Comment # 3</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Additional selection tests and interpolation fix"
href="https://bugs.webkit.org/show_bug.cgi?id=167171">bug 167171</a>
from <span class="vcard"><a class="email" href="mailto:simon.fraser@apple.com" title="Simon Fraser (smfr) <simon.fraser@apple.com>"> <span class="fn">Simon Fraser (smfr)</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=299173&action=diff" name="attach_299173" title="Patch">attachment 299173</a> <a href="attachment.cgi?id=299173&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299173&action=review">https://bugs.webkit.org/attachment.cgi?id=299173&action=review</a>
<span class="quote">> LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html:17
> + uiController.uiScriptComplete();
> + });</span >
Weird spacing.
<span class="quote">> LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html:35
> + {</span >
I think canonical formatting would outdent this paren.
<span class="quote">> LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html:83
> + testRunner.runUIScript(getDragScript(55,90,0,90), function(result) {
> + if (document.getSelection().toString() == "aliqua. Ut")</span >
I'm a bit concerned that small changes in text rendering (that often happen between OS releases) would break this test. Maybe make the text monospaced and of a fairly large size to reduce the likelihood.
<span class="quote">> LayoutTests/fast/events/touch/ios/long-press-then-drag-left-to-change-selected-text.html:137
> + <meta name="viewport" content="initial-scale=1"></span >
We usually put this at the top of the <head>. I think your test needs the flexibleViewport flag to make this do anything.
<span class="quote">> LayoutTests/fast/events/touch/ios/long-press-then-drag-right-to-change-selected-text.html:16
> + uiController.uiScriptComplete();</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>