[Webkit-unassigned] [Bug 167022] Ignore Connection Assertion if we are not using connection to send messages

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 18 11:20:39 PST 2017


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
 Attachment #299040|review?                     |review+
              Flags|                            |

--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 299040
  --> https://bugs.webkit.org/attachment.cgi?id=299040

View in context: https://bugs.webkit.org/attachment.cgi?id=299040&action=review

> Source/WebKit2/UIProcess/ChildProcessProxy.h:55
> +    bool hasConnection(IPC::Connection& connection)

I suggest both making this function const and making the argument a const&.

> Source/WebKit2/UIProcess/ChildProcessProxy.h:57
> +        return (m_connection.get() == &connection);

I suggest omitting the parentheses and the get() because RefPtr == raw pointer should compile without a get().

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170118/6ad7be90/attachment.html>

More information about the webkit-unassigned mailing list