<html>
    <head>
      <base href="https://bugs.webkit.org/" />
    </head>
    <body><span class="vcard"><a class="email" href="mailto:darin&#64;apple.com" title="Darin Adler &lt;darin&#64;apple.com&gt;"> <span class="fn">Darin Adler</span></a>
</span> changed
              <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Ignore Connection Assertion if we are not using connection to send messages"
   href="https://bugs.webkit.org/show_bug.cgi?id=167022">bug 167022</a>
        <br>
             <table border="1" cellspacing="0" cellpadding="8">
          <tr>
            <th>What</th>
            <th>Removed</th>
            <th>Added</th>
          </tr>

         <tr>
           <td style="text-align:right;">Attachment #299040 Flags</td>
           <td>review?
           </td>
           <td>review+
           </td>
         </tr></table>
      <p>
        <div>
            <b><a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Ignore Connection Assertion if we are not using connection to send messages"
   href="https://bugs.webkit.org/show_bug.cgi?id=167022#c11">Comment # 11</a>
              on <a class="bz_bug_link 
          bz_status_NEW "
   title="NEW - Ignore Connection Assertion if we are not using connection to send messages"
   href="https://bugs.webkit.org/show_bug.cgi?id=167022">bug 167022</a>
              from <span class="vcard"><a class="email" href="mailto:darin&#64;apple.com" title="Darin Adler &lt;darin&#64;apple.com&gt;"> <span class="fn">Darin Adler</span></a>
</span></b>
        <pre>Comment on <span class=""><a href="attachment.cgi?id=299040&amp;action=diff" name="attach_299040" title="Patch">attachment 299040</a> <a href="attachment.cgi?id=299040&amp;action=edit" title="Patch">[details]</a></span>
Patch

View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299040&amp;action=review">https://bugs.webkit.org/attachment.cgi?id=299040&amp;action=review</a>

<span class="quote">&gt; Source/WebKit2/UIProcess/ChildProcessProxy.h:55
&gt; +    bool hasConnection(IPC::Connection&amp; connection)</span >

I suggest both making this function const and making the argument a const&amp;.

<span class="quote">&gt; Source/WebKit2/UIProcess/ChildProcessProxy.h:57
&gt; +        return (m_connection.get() == &amp;connection);</span >

I suggest omitting the parentheses and the get() because RefPtr == raw pointer should compile without a get().</pre>
        </div>
      </p>
      <hr>
      <span>You are receiving this mail because:</span>
      
      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
    </body>
</html>