[Webkit-unassigned] [Bug 167152] 'buildbot-syncer.js' should be able to determine force build argument from a list of possible repositories.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 17 20:46:35 PST 2017


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #299115|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 299115
  --> https://bugs.webkit.org/attachment.cgi?id=299115

View in context: https://bugs.webkit.org/attachment.cgi?id=299115&action=review

r=me assuming all the issues below are addressed.

> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:231
> +                for (let rootCandidate of value['rootCandidates']) {
> +                    if(!(rootCandidate in repositoryByName))
> +                        continue;

We should just use filter instead.
e.g. const filteredOptions = value['rootOptions'].filter((option) => option in repositoryByName);
and then check that the filtered result is of length 1.

> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:394
> +            case 'rootCandidates': //fallthrough

Nit: Capitalize f and there should be a space between // and f.

> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:19
> +                    'opensource': {'rootCandidates': ['WebKit-SVN', 'WebKit-Git']},

I don't think the term "candidate" makes sense given we're picking one of them.
How about 'rootOptions' or 'rootChoices'?

> Websites/perf.webkit.org/unit-tests/resources/mock-v3-models.js:21
> +            MockModels.opensourceRepository = Repository.ensureSingleton(17, {name: 'WebKit-Git'});

I don't think we want to call this opensourceRepository. Probably something like webkitGit?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170118/633bd9d4/attachment.html>

More information about the webkit-unassigned mailing list