<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - 'buildbot-syncer.js' should be able to determine force build argument from a list of possible repositories."
href="https://bugs.webkit.org/show_bug.cgi?id=167152">bug 167152</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #299115 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - 'buildbot-syncer.js' should be able to determine force build argument from a list of possible repositories."
href="https://bugs.webkit.org/show_bug.cgi?id=167152#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - 'buildbot-syncer.js' should be able to determine force build argument from a list of possible repositories."
href="https://bugs.webkit.org/show_bug.cgi?id=167152">bug 167152</a>
from <span class="vcard"><a class="email" href="mailto:rniwa@webkit.org" title="Ryosuke Niwa <rniwa@webkit.org>"> <span class="fn">Ryosuke Niwa</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=299115&action=diff" name="attach_299115" title="Patch">attachment 299115</a> <a href="attachment.cgi?id=299115&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299115&action=review">https://bugs.webkit.org/attachment.cgi?id=299115&action=review</a>
r=me assuming all the issues below are addressed.
<span class="quote">> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:231
> + for (let rootCandidate of value['rootCandidates']) {
> + if(!(rootCandidate in repositoryByName))
> + continue;</span >
We should just use filter instead.
e.g. const filteredOptions = value['rootOptions'].filter((option) => option in repositoryByName);
and then check that the filtered result is of length 1.
<span class="quote">> Websites/perf.webkit.org/tools/js/buildbot-syncer.js:394
> + case 'rootCandidates': //fallthrough</span >
Nit: Capitalize f and there should be a space between // and f.
<span class="quote">> Websites/perf.webkit.org/unit-tests/buildbot-syncer-tests.js:19
> + 'opensource': {'rootCandidates': ['WebKit-SVN', 'WebKit-Git']},</span >
I don't think the term "candidate" makes sense given we're picking one of them.
How about 'rootOptions' or 'rootChoices'?
<span class="quote">> Websites/perf.webkit.org/unit-tests/resources/mock-v3-models.js:21
> + MockModels.opensourceRepository = Repository.ensureSingleton(17, {name: 'WebKit-Git'});</span >
I don't think we want to call this opensourceRepository. Probably something like webkitGit?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>