[Webkit-unassigned] [Bug 166973] Construct URLSearchParams from array or object

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166973

--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
I have four issues with this so far:
1) The spec doesn't specify the order we iterate the record in.  Our implementation is a HashMap<String, String>.  Is this wrong?
2) There is no test with a sequence of one USVString.  A *very* poor implementation might go out of bounds here.  I think it's worth testing.
3) There probably isn't a test for setting or appending a '+' in an existing URLSearchParams.  Lots of places we replace a '+' with a ' ', but my implementation doesn't in set or append, but there seems to be such a test with the record constructor.  urlsearchparams-stringifier.html has a contradictory test verifying that '+' is stringified to '+'.
4) The HashMap<String, String> I get from the values you see in the patch I'm about to upload.  Is that a problem in our record implementation?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170117/037b03c2/attachment.html>