<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Construct URLSearchParams from array or object"
href="https://bugs.webkit.org/show_bug.cgi?id=166973#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Construct URLSearchParams from array or object"
href="https://bugs.webkit.org/show_bug.cgi?id=166973">bug 166973</a>
from <span class="vcard"><a class="email" href="mailto:achristensen@apple.com" title="Alex Christensen <achristensen@apple.com>"> <span class="fn">Alex Christensen</span></a>
</span></b>
<pre>I have four issues with this so far:
1) The spec doesn't specify the order we iterate the record in. Our implementation is a HashMap<String, String>. Is this wrong?
2) There is no test with a sequence of one USVString. A *very* poor implementation might go out of bounds here. I think it's worth testing.
3) There probably isn't a test for setting or appending a '+' in an existing URLSearchParams. Lots of places we replace a '+' with a ' ', but my implementation doesn't in set or append, but there seems to be such a test with the record constructor. urlsearchparams-stringifier.html has a contradictory test verifying that '+' is stringified to '+'.
4) The HashMap<String, String> I get from the values you see in the patch I'm about to upload. Is that a problem in our record implementation?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>