[Webkit-unassigned] [Bug 166886] [GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166886

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |calvaris at igalia.com

--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
(In reply to comment #3)
> >> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:353
> >> +        auto& buffer = channelBufferList[i];
> > 
> > Specify the type, please
> 
> why?
> 
> >> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:362
> >> +        auto& appsrc = priv->sources[i];
> > 
> > Specify the type, please
> 
> why?

Cause I thought it was better for readability, but given the latest discussions on -dev and -reviewers it does not matter anymore.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170111/ba2aeab7/attachment.html>