<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=166886">bug 166886</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">CC</td>
<td>
</td>
<td>calvaris@igalia.com
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=166886#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer"
href="https://bugs.webkit.org/show_bug.cgi?id=166886">bug 166886</a>
from <span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span></b>
<pre>(In reply to <a href="show_bug.cgi?id=166886#c3">comment #3</a>)
<span class="quote">> >> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:353
> >> + auto& buffer = channelBufferList[i];
> >
> > Specify the type, please
>
> why?
>
> >> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:362
> >> + auto& appsrc = priv->sources[i];
> >
> > Specify the type, please
>
> why?</span >
Cause I thought it was better for readability, but given the latest discussions on -dev and -reviewers it does not matter anymore.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>