[Webkit-unassigned] [Bug 166886] [GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166886

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 298454
  --> https://bugs.webkit.org/attachment.cgi?id=298454
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=298454&action=review

>> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:353
>> +        auto& buffer = channelBufferList[i];
> 
> Specify the type, please

why?

>> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:362
>> +        auto& appsrc = priv->sources[i];
> 
> Specify the type, please

why?

>> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:403
>> +        src->priv->pool = adoptGRef(gst_buffer_pool_new());
> 
> gst_buffer_pool_new returns a floating reference. According to the defined adoptGRef for this time, this should trigger the ASSERT.
> 
> Not adopting is ok here.
> 
> Actually in line 221 a similar thing is done correctly.

Right!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170110/d6443bb2/attachment.html>