[Webkit-unassigned] [Bug 166886] [GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 10 06:19:10 PST 2017


Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #298454|review?                     |review-
              Flags|                            |

--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 298454
  --> https://bugs.webkit.org/attachment.cgi?id=298454

View in context: https://bugs.webkit.org/attachment.cgi?id=298454&action=review

> Source/WebCore/ChangeLog:9
> +        smart pointers, uses WTF::Vactor instead of GSList and simplifies the code to map/unmap GstBuffers.


> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:353
> +        auto& buffer = channelBufferList[i];

Specify the type, please

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:362
> +        auto& appsrc = priv->sources[i];

Specify the type, please

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:403
> +        src->priv->pool = adoptGRef(gst_buffer_pool_new());

gst_buffer_pool_new returns a floating reference. According to the defined adoptGRef for this time, this should trigger the ASSERT.

Not adopting is ok here.

Actually in line 221 a similar thing is done correctly.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170110/414ba7a5/attachment.html>

More information about the webkit-unassigned mailing list