[Webkit-unassigned] [Bug 166722] [SOUP] AddressSanitizer: heap-use-after-free under WTF::String::fromUTF8()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=166722

Milan Crha <mcrha at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #298095|0                           |1
        is obsolete|                            |
 Attachment #298095|review?                     |
              Flags|                            |
 Attachment #298105|                            |review?, commit-queue?
              Flags|                            |

--- Comment #6 from Milan Crha <mcrha at redhat.com> ---
Created attachment 298105
  --> https://bugs.webkit.org/attachment.cgi?id=298105&action=review
proposed patch ][

(In reply to comment #4)
> Comment on attachment 298095 [details]
> > Source/WebCore/ChangeLog:8
> > +        No new tests (OOPS!).
> 
> You should remove this line since this patch shouldn't affect tests. And
> also explain the change, what was broken and how this patch fixes it.

Ah, right, that's a long time since I sent any patches to webkit.

> domain_utf8 -> domainUTF8

Yeah, I'm sorry (bug #166725 filled).

> I don't understand why we can't use the temporary here. Can
> soup_tld_get_base_domain() return the passed in hostname?

Right, it consumes 'const char *' and also returns 'const char *', then it makes sense it returns something from within the passed-in string. I tried to write some so-called explanation to the ChangeLog, though it sounds odd to me. I couldn't come up with anything better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170105/4da37662/attachment.html>