<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:mcrha@redhat.com" title="Milan Crha <mcrha@redhat.com>"> <span class="fn">Milan Crha</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] AddressSanitizer: heap-use-after-free under WTF::String::fromUTF8()"
href="https://bugs.webkit.org/show_bug.cgi?id=166722">bug 166722</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #298095 is obsolete</td>
<td>
</td>
<td>1
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #298095 Flags</td>
<td>review?
</td>
<td>
</td>
</tr>
<tr>
<td style="text-align:right;">Attachment #298105 Flags</td>
<td>
</td>
<td>review?, commit-queue?
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] AddressSanitizer: heap-use-after-free under WTF::String::fromUTF8()"
href="https://bugs.webkit.org/show_bug.cgi?id=166722#c6">Comment # 6</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] AddressSanitizer: heap-use-after-free under WTF::String::fromUTF8()"
href="https://bugs.webkit.org/show_bug.cgi?id=166722">bug 166722</a>
from <span class="vcard"><a class="email" href="mailto:mcrha@redhat.com" title="Milan Crha <mcrha@redhat.com>"> <span class="fn">Milan Crha</span></a>
</span></b>
<pre>Created <span class=""><a href="attachment.cgi?id=298105&action=diff" name="attach_298105" title="proposed patch ][">attachment 298105</a> <a href="attachment.cgi?id=298105&action=edit" title="proposed patch ][">[details]</a></span>
proposed patch ][
(In reply to <a href="show_bug.cgi?id=166722#c4">comment #4</a>)
<span class="quote">> Comment on <span class="bz_obsolete"><a href="attachment.cgi?id=298095&action=diff" name="attach_298095" title="proposed patch">attachment 298095</a> <a href="attachment.cgi?id=298095&action=edit" title="proposed patch">[details]</a></span>
> > Source/WebCore/ChangeLog:8
> > + No new tests (OOPS!).
>
> You should remove this line since this patch shouldn't affect tests. And
> also explain the change, what was broken and how this patch fixes it.</span >
Ah, right, that's a long time since I sent any patches to webkit.
<span class="quote">> domain_utf8 -> domainUTF8</span >
Yeah, I'm sorry (<a class="bz_bug_link
bz_status_NEW "
title="NEW - prepare-ChangeLog doesn't check coding style by default, even it should"
href="show_bug.cgi?id=166725">bug #166725</a> filled).
<span class="quote">> I don't understand why we can't use the temporary here. Can
> soup_tld_get_base_domain() return the passed in hostname?</span >
Right, it consumes 'const char *' and also returns 'const char *', then it makes sense it returns something from within the passed-in string. I tried to write some so-called explanation to the ChangeLog, though it sounds odd to me. I couldn't come up with anything better.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>