[Webkit-unassigned] [Bug 166722] [SOUP] AddressSanitizer: heap-use-after-free under WTF::String::fromUTF8()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 5 05:49:18 PST 2017
https://bugs.webkit.org/show_bug.cgi?id=166722
Carlos Garcia Campos <cgarcia at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #298095|commit-queue? |commit-queue-
Flags| |
--- Comment #4 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 298095
--> https://bugs.webkit.org/attachment.cgi?id=298095
proposed patch
View in context: https://bugs.webkit.org/attachment.cgi?id=298095&action=review
> Source/WebCore/ChangeLog:8
> + No new tests (OOPS!).
You should remove this line since this patch shouldn't affect tests. And also explain the change, what was broken and how this patch fixes it.
> Source/WebCore/platform/soup/PublicSuffixSoup.cpp:50
> + CString domain_utf8 = domain.utf8();
domain_utf8 -> domainUTF8
> Source/WebCore/platform/soup/PublicSuffixSoup.cpp:52
> + if (const char* baseDomain = soup_tld_get_base_domain(domain_utf8.data(), &error.outPtr()))
> return String::fromUTF8(baseDomain);
I don't understand why we can't use the temporary here. Can soup_tld_get_base_domain() return the passed in hostname?
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170105/b7818d62/attachment-0001.html>
More information about the webkit-unassigned
mailing list