<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] AddressSanitizer: heap-use-after-free under WTF::String::fromUTF8()"
href="https://bugs.webkit.org/show_bug.cgi?id=166722">bug 166722</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #298095 Flags</td>
<td>commit-queue?
</td>
<td>commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] AddressSanitizer: heap-use-after-free under WTF::String::fromUTF8()"
href="https://bugs.webkit.org/show_bug.cgi?id=166722#c4">Comment # 4</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [SOUP] AddressSanitizer: heap-use-after-free under WTF::String::fromUTF8()"
href="https://bugs.webkit.org/show_bug.cgi?id=166722">bug 166722</a>
from <span class="vcard"><a class="email" href="mailto:cgarcia@igalia.com" title="Carlos Garcia Campos <cgarcia@igalia.com>"> <span class="fn">Carlos Garcia Campos</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=298095&action=diff" name="attach_298095" title="proposed patch">attachment 298095</a> <a href="attachment.cgi?id=298095&action=edit" title="proposed patch">[details]</a></span>
proposed patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=298095&action=review">https://bugs.webkit.org/attachment.cgi?id=298095&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:8
> + No new tests (OOPS!).</span >
You should remove this line since this patch shouldn't affect tests. And also explain the change, what was broken and how this patch fixes it.
<span class="quote">> Source/WebCore/platform/soup/PublicSuffixSoup.cpp:50
> + CString domain_utf8 = domain.utf8();</span >
domain_utf8 -> domainUTF8
<span class="quote">> Source/WebCore/platform/soup/PublicSuffixSoup.cpp:52
> + if (const char* baseDomain = soup_tld_get_base_domain(domain_utf8.data(), &error.outPtr()))
> return String::fromUTF8(baseDomain);</span >
I don't understand why we can't use the temporary here. Can soup_tld_get_base_domain() return the passed in hostname?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>