[Webkit-unassigned] [Bug 168699] [GTK] Hangs when showing Google search results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 23:04:16 PST 2017


--- Comment #8 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 302509
  --> https://bugs.webkit.org/attachment.cgi?id=302509

View in context: https://bugs.webkit.org/attachment.cgi?id=302509&action=review

> Source/WebKit2/ChangeLog:13
> +        socket monitor as readSocketMonitor and adds another one for polling output. When sendsmg fails with


> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:365
> +bool Connection::sendOutputMessage(UnixMessage& outputMessage)

Mac port uses unique_ptr. You don't use unique_ptr<UnixMessage> for outputMessage for performance?

> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:458
> +                            sendOutputMessage(*message);

You don't need to check the return value of sendOutputMessage?

> Source/WebKit2/Platform/IPC/unix/UnixMessage.h:66
> +class AttachmentInfo {

You don't need to move AttachmentInfo, too.

> Source/WebKit2/Platform/IPC/unix/UnixMessage.h:114
> +            memcpy(m_body, other.m_body, m_messageInfo.bodySize());

You don't need to copy the body if m_messageInfo.isMessageBodyIsOutOfLine().

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170224/85e393ec/attachment-0001.html>

More information about the webkit-unassigned mailing list