<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Hangs when showing Google search results"
href="https://bugs.webkit.org/show_bug.cgi?id=168699#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GTK] Hangs when showing Google search results"
href="https://bugs.webkit.org/show_bug.cgi?id=168699">bug 168699</a>
from <span class="vcard"><a class="email" href="mailto:Hironori.Fujii@sony.com" title="Fujii Hironori <Hironori.Fujii@sony.com>"> <span class="fn">Fujii Hironori</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=302509&action=diff" name="attach_302509" title="Patch">attachment 302509</a> <a href="attachment.cgi?id=302509&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=302509&action=review">https://bugs.webkit.org/attachment.cgi?id=302509&action=review</a>
<span class="quote">> Source/WebKit2/ChangeLog:13
> + socket monitor as readSocketMonitor and adds another one for polling output. When sendsmg fails with</span >
s/sendsmg/sendmsg/
<span class="quote">> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:365
> +bool Connection::sendOutputMessage(UnixMessage& outputMessage)</span >
Mac port uses unique_ptr. You don't use unique_ptr<UnixMessage> for outputMessage for performance?
<span class="quote">> Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:458
> + sendOutputMessage(*message);</span >
You don't need to check the return value of sendOutputMessage?
<span class="quote">> Source/WebKit2/Platform/IPC/unix/UnixMessage.h:66
> +class AttachmentInfo {</span >
You don't need to move AttachmentInfo, too.
<span class="quote">> Source/WebKit2/Platform/IPC/unix/UnixMessage.h:114
> + memcpy(m_body, other.m_body, m_messageInfo.bodySize());</span >
You don't need to copy the body if m_messageInfo.isMessageBodyIsOutOfLine().</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>