[Webkit-unassigned] [Bug 168626] Add machine-readable results for bindings tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 17:27:25 PST 2017


--- Comment #8 from Dean Johnson <dean_johnson at apple.com> ---
Comment on attachment 302581
  --> https://bugs.webkit.org/attachment.cgi?id=302581

View in context: https://bugs.webkit.org/attachment.cgi?id=302581&action=review

Looks good overall. Food for thought below.

> Tools/Scripts/webkitpy/bindings/main.py:47
> +        if self.json_file_name:

All of the 'if self.json_file_name' might be a bit pre-mature for optimization. I don't think we will really see a performance hit from always appending errors/failure. The only one conditional I feel should remain is the one that actually does the writing to a file.

> Tools/Scripts/webkitpy/bindings/main.py:118
> +                if self.json_file_name:


> Tools/Scripts/webkitpy/bindings/main.py:125
> +                if self.json_file_name:


You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170224/35cdcf9a/attachment.html>

More information about the webkit-unassigned mailing list