<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Add machine-readable results for bindings tests"
href="https://bugs.webkit.org/show_bug.cgi?id=168626#c8">Comment # 8</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Add machine-readable results for bindings tests"
href="https://bugs.webkit.org/show_bug.cgi?id=168626">bug 168626</a>
from <span class="vcard"><a class="email" href="mailto:dean_johnson@apple.com" title="Dean Johnson <dean_johnson@apple.com>"> <span class="fn">Dean Johnson</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=302581&action=diff" name="attach_302581" title="Patch">attachment 302581</a> <a href="attachment.cgi?id=302581&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=302581&action=review">https://bugs.webkit.org/attachment.cgi?id=302581&action=review</a>
Looks good overall. Food for thought below.
<span class="quote">> Tools/Scripts/webkitpy/bindings/main.py:47
> + if self.json_file_name:</span >
All of the 'if self.json_file_name' might be a bit pre-mature for optimization. I don't think we will really see a performance hit from always appending errors/failure. The only one conditional I feel should remain is the one that actually does the writing to a file.
<span class="quote">> Tools/Scripts/webkitpy/bindings/main.py:118
> + if self.json_file_name:</span >
Ditto.
<span class="quote">> Tools/Scripts/webkitpy/bindings/main.py:125
> + if self.json_file_name:</span >
Ditto.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>