[Webkit-unassigned] [Bug 123438] [GStreamer] Adopt nullptr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 23 02:18:52 PST 2017


Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
 Attachment #302440|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 302440
  --> https://bugs.webkit.org/attachment.cgi?id=302440

View in context: https://bugs.webkit.org/attachment.cgi?id=302440&action=review

> Source/WebCore/ChangeLog:10
> +        The per-file and per-function explanations are left blank because the change is very simple,
> +        so there's no need to explain it once per source file.

You don't need this explanation. The first line is enough.

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1180
> +        processTableOfContentsEntry(static_cast<GstTocEntry*>(i->data), nullptr);

The null argument of this function is unused and it does not take part of any API inside WebKit so I'd say we remove it from the calls and from the declaration. Obviously, the UNUSED_PARAM would be useless too.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170223/92ae6712/attachment-0001.html>

More information about the webkit-unassigned mailing list