<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Adopt nullptr"
href="https://bugs.webkit.org/show_bug.cgi?id=123438">bug 123438</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #302440 Flags</td>
<td>review?
</td>
<td>review+, commit-queue-
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Adopt nullptr"
href="https://bugs.webkit.org/show_bug.cgi?id=123438#c2">Comment # 2</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Adopt nullptr"
href="https://bugs.webkit.org/show_bug.cgi?id=123438">bug 123438</a>
from <span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=302440&action=diff" name="attach_302440" title="Patch">attachment 302440</a> <a href="attachment.cgi?id=302440&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=302440&action=review">https://bugs.webkit.org/attachment.cgi?id=302440&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:10
> + The per-file and per-function explanations are left blank because the change is very simple,
> + so there's no need to explain it once per source file.</span >
You don't need this explanation. The first line is enough.
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1180
> + processTableOfContentsEntry(static_cast<GstTocEntry*>(i->data), nullptr);</span >
The null argument of this function is unused and it does not take part of any API inside WebKit so I'd say we remove it from the calls and from the declaration. Obviously, the UNUSED_PARAM would be useless too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>