[Webkit-unassigned] [Bug 167016] [GStreamer] Several layout tests trigger GStreamer-CRITICAL **: gst_bin_get_by_name: assertion 'GST_IS_BIN (bin)' failed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167016

Xabier Rodríguez Calvar <calvaris at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #302388|review?                     |review+
              Flags|                            |

--- Comment #5 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 302388
  --> https://bugs.webkit.org/attachment.cgi?id=302388
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=302388&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore::MediaPlayerPrivateGStreamer::ensureAudioSourceProvider): Create the AudioSourceProvider is needed.

I guess you mean "if"

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2059
> +void MediaPlayerPrivateGStreamer::ensureAudioSourceProvider()
> +{
> +    if (!m_audioSourceProvider)
> +        m_audioSourceProvider = std::make_unique<AudioSourceProviderGStreamer>();
> +}
> +
> +AudioSourceProvider* MediaPlayerPrivateGStreamer::audioSourceProvider()
> +{
> +    ensureAudioSourceProvider();
> +    return m_audioSourceProvider.get();
> +}

I would probably avoid the ensure function and use audioSourceProvider in all cases above. Besides, it might be interesting to make it inline if possible.

But proposed solution is fine with me too.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170223/5e0f810f/attachment.html>