<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Several layout tests trigger GStreamer-CRITICAL **: gst_bin_get_by_name: assertion 'GST_IS_BIN (bin)' failed"
href="https://bugs.webkit.org/show_bug.cgi?id=167016">bug 167016</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #302388 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Several layout tests trigger GStreamer-CRITICAL **: gst_bin_get_by_name: assertion 'GST_IS_BIN (bin)' failed"
href="https://bugs.webkit.org/show_bug.cgi?id=167016#c5">Comment # 5</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [GStreamer] Several layout tests trigger GStreamer-CRITICAL **: gst_bin_get_by_name: assertion 'GST_IS_BIN (bin)' failed"
href="https://bugs.webkit.org/show_bug.cgi?id=167016">bug 167016</a>
from <span class="vcard"><a class="email" href="mailto:calvaris@igalia.com" title="Xabier Rodríguez Calvar <calvaris@igalia.com>"> <span class="fn">Xabier Rodríguez Calvar</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=302388&action=diff" name="attach_302388" title="Patch">attachment 302388</a> <a href="attachment.cgi?id=302388&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=302388&action=review">https://bugs.webkit.org/attachment.cgi?id=302388&action=review</a>
<span class="quote">> Source/WebCore/ChangeLog:16
> + (WebCore::MediaPlayerPrivateGStreamer::ensureAudioSourceProvider): Create the AudioSourceProvider is needed.</span >
I guess you mean "if"
<span class="quote">> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2059
> +void MediaPlayerPrivateGStreamer::ensureAudioSourceProvider()
> +{
> + if (!m_audioSourceProvider)
> + m_audioSourceProvider = std::make_unique<AudioSourceProviderGStreamer>();
> +}
> +
> +AudioSourceProvider* MediaPlayerPrivateGStreamer::audioSourceProvider()
> +{
> + ensureAudioSourceProvider();
> + return m_audioSourceProvider.get();
> +}</span >
I would probably avoid the ensure function and use audioSourceProvider in all cases above. Besides, it might be interesting to make it inline if possible.
But proposed solution is fine with me too.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>