[Webkit-unassigned] [Bug 167962] [ESnext] Implement Object Rest - Implementing Object Rest Destructuring

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=167962

--- Comment #16 from Caio Lima <ticaiolima at gmail.com> ---
Comment on attachment 301324
  --> https://bugs.webkit.org/attachment.cgi?id=301324
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301324&action=review

>> Source/JavaScriptCore/parser/Parser.cpp:1019
>> +                failIfFalse(innerPattern, "Cannot parse this destructuring pattern");
> 
> I think you just want to do propageError(); here

Sure. This way we keep the error message more clear.

>> Source/JavaScriptCore/runtime/JSGlobalObject.h:117
>> +    macro(Set, set, set, JSSet, Set, object) \
> 
> Why did you move this?

I'm using it in copyPropertiesData (Source/JavaScriptCore/builtins/GlobalOperations.js) because it makes the algorithm O(n + m) where n = Object.getOwnPropertyNames(source).length and m = excludedList.length. Does it make sense?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170223/703d0470/attachment.html>