<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - [ESnext] Implement Object Rest - Implementing Object Rest Destructuring"
href="https://bugs.webkit.org/show_bug.cgi?id=167962#c16">Comment # 16</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - [ESnext] Implement Object Rest - Implementing Object Rest Destructuring"
href="https://bugs.webkit.org/show_bug.cgi?id=167962">bug 167962</a>
from <span class="vcard"><a class="email" href="mailto:ticaiolima@gmail.com" title="Caio Lima <ticaiolima@gmail.com>"> <span class="fn">Caio Lima</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=301324&action=diff" name="attach_301324" title="Patch">attachment 301324</a> <a href="attachment.cgi?id=301324&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=301324&action=review">https://bugs.webkit.org/attachment.cgi?id=301324&action=review</a>
<span class="quote">>> Source/JavaScriptCore/parser/Parser.cpp:1019
>> + failIfFalse(innerPattern, "Cannot parse this destructuring pattern");
>
> I think you just want to do propageError(); here</span >
Sure. This way we keep the error message more clear.
<span class="quote">>> Source/JavaScriptCore/runtime/JSGlobalObject.h:117
>> + macro(Set, set, set, JSSet, Set, object) \
>
> Why did you move this?</span >
I'm using it in copyPropertiesData (Source/JavaScriptCore/builtins/GlobalOperations.js) because it makes the algorithm O(n + m) where n = Object.getOwnPropertyNames(source).length and m = excludedList.length. Does it make sense?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>