[Webkit-unassigned] [Bug 165028] Reduce platform ifdefs in WebKit2 custom protocols implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=165028

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #299133|review?                     |review+
              Flags|                            |

--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 299133
  --> https://bugs.webkit.org/attachment.cgi?id=299133
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=299133&action=review

> Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h:46
> +    void startLoading(CustomProtocolManagerProxy&, uint64_t /*customProtocolID*/, const WebCore::ResourceRequest&) override;
> +    void stopLoading(CustomProtocolManagerProxy&, uint64_t /*customProtocolID*/) override;
> +    void invalidate(CustomProtocolManagerProxy&) override;

WebKit coding style says to use final, not override.

> Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mmSource/WebKit2/UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:143
> +    // FIXME: iterate the loader map and remove loaders for the given manager.

Why is it safe to leave this unimplemented?

> Source/WebKit2/UIProcess/WebProcessPool.cpp:371
> +    for (const auto& scheme : globalURLSchemesWithCustomProtocolHandlers())
> +        parameters.urlSchemesRegisteredForCustomProtocols.append(scheme);
> +
> +    for (const auto& scheme : m_urlSchemesRegisteredForCustomProtocols)
> +        parameters.urlSchemesRegisteredForCustomProtocols.append(scheme);

I suggest just auto& rather than const auto&.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170214/ae67f3b2/attachment.html>