<html>
<head>
<base href="https://bugs.webkit.org/" />
</head>
<body><span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span> changed
<a class="bz_bug_link
bz_status_NEW "
title="NEW - Reduce platform ifdefs in WebKit2 custom protocols implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=165028">bug 165028</a>
<br>
<table border="1" cellspacing="0" cellpadding="8">
<tr>
<th>What</th>
<th>Removed</th>
<th>Added</th>
</tr>
<tr>
<td style="text-align:right;">Attachment #299133 Flags</td>
<td>review?
</td>
<td>review+
</td>
</tr></table>
<p>
<div>
<b><a class="bz_bug_link
bz_status_NEW "
title="NEW - Reduce platform ifdefs in WebKit2 custom protocols implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=165028#c9">Comment # 9</a>
on <a class="bz_bug_link
bz_status_NEW "
title="NEW - Reduce platform ifdefs in WebKit2 custom protocols implementation"
href="https://bugs.webkit.org/show_bug.cgi?id=165028">bug 165028</a>
from <span class="vcard"><a class="email" href="mailto:darin@apple.com" title="Darin Adler <darin@apple.com>"> <span class="fn">Darin Adler</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=299133&action=diff" name="attach_299133" title="Patch">attachment 299133</a> <a href="attachment.cgi?id=299133&action=edit" title="Patch">[details]</a></span>
Patch
View in context: <a href="https://bugs.webkit.org/attachment.cgi?id=299133&action=review">https://bugs.webkit.org/attachment.cgi?id=299133&action=review</a>
<span class="quote">> Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h:46
> + void startLoading(CustomProtocolManagerProxy&, uint64_t /*customProtocolID*/, const WebCore::ResourceRequest&) override;
> + void stopLoading(CustomProtocolManagerProxy&, uint64_t /*customProtocolID*/) override;
> + void invalidate(CustomProtocolManagerProxy&) override;</span >
WebKit coding style says to use final, not override.
<span class="quote">> Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mmSource/WebKit2/UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:143
> + // FIXME: iterate the loader map and remove loaders for the given manager.</span >
Why is it safe to leave this unimplemented?
<span class="quote">> Source/WebKit2/UIProcess/WebProcessPool.cpp:371
> + for (const auto& scheme : globalURLSchemesWithCustomProtocolHandlers())
> + parameters.urlSchemesRegisteredForCustomProtocols.append(scheme);
> +
> + for (const auto& scheme : m_urlSchemesRegisteredForCustomProtocols)
> + parameters.urlSchemesRegisteredForCustomProtocols.append(scheme);</span >
I suggest just auto& rather than const auto&.</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
</body>
</html>