[Webkit-unassigned] [Bug 168299] [SOUP] Ensure a response MIME type when Content-Type is missing and sniffing not allowed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=168299

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301481|review?                     |review+
              Flags|                            |

--- Comment #2 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 301481
  --> https://bugs.webkit.org/attachment.cgi?id=301481
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=301481&action=review

> Source/WebKit2/NetworkProcess/soup/NetworkDataTaskSoup.cpp:334
> +        }

What about just adding

if (m_response.mimeType().isEmpty() && m_soupMessage->status_code != SOUP_STATUS_NOT_MODIFIED)
    m_response.setMimeType(MIMETypeRegistry::getMIMETypeForPath(m_response.url().path()));

to the previous code? I prefer that option because it  clearly shows that the call to updateFromSoupMessage is unconditional.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20170214/7b58495e/attachment.html>